[
https://issues.apache.org/jira/browse/HIVE-23965?focusedWorklogId=465105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465105
]
ASF GitHub Bot logged work on HIVE-23965:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/20 17:25
Start Date: 31/Jul/20 17:25
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request #1347:
URL: https://github.com/apache/hive/pull/1347
### What changes were proposed in this pull request and why?
1. Use Dockerized postgres metastore with TPC-DS 30TB dump
2. Use Hive config properties obtained and curated from real-life usages
3. Allow AbstractCliConfig to override metastore DB type
4. Rework CorePerfCliDriver to allow pre-initialized metastores
Extract TPCDS specific code to subclass and document appropriately
clarifying inaccuracies regarding the size of the tables in the javadoc.
Remove system property settings in the initialization of the driver and
leave in the configuration to set it up if needed. This is necessary to
be able to use the driver with a preinitialised metastore.
Remove redundant logs in System.err. Logging and throwing an exception
is an anti-pattern.
Replace assertions with exceptions and improve the messages.
5. Give more meaningful names to TPCDS related CLI configurations
6. Disable queries 30, 74, 84 with appropriate JIRA reference
7. Add TPC-DS query plans for the new driver (TestTezTPCDS30TBCliDriver)
8. Consider hive.current.database property when returning the session's
current db to avoid prefixing every query with the name of the database
9. Upgrade postgres JDBC driver to version 42.2.14 to be compatible
with the docker image used.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`mvn test -Dtest=TestTezTPCDS30TBCliDriver -Dtest.output.overwrite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 465105)
Remaining Estimate: 0h
Time Spent: 10m
> Improve plan regression tests using TPCDS30TB metastore dump and custom
> configs
> -------------------------------------------------------------------------------
>
> Key: HIVE-23965
> URL: https://issues.apache.org/jira/browse/HIVE-23965
> Project: Hive
> Issue Type: Improvement
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The existing regression tests (HIVE-12586) based on TPC-DS have certain
> shortcomings:
> The table statistics do not reflect cardinalities from a specific TPC-DS
> scale factor (SF). Some tables are from a 30TB dataset, others from 200GB
> dataset, and others from a 3GB dataset. This mix leads to plans that may
> never appear when using an actual TPC-DS dataset.
> The existing statistics do not contain information about partitions something
> that can have a big impact on the resulting plans.
> The existing regression tests rely on more or less on the default
> configuration (hive-site.xml). In real-life scenarios though some of the
> configurations differ and may impact the choices of the optimizer.
> This issue aims to address the above shortcomings by using a curated
> TPCDS30TB metastore dump along with some custom hive configurations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
