[ https://issues.apache.org/jira/browse/HIVE-23951?focusedWorklogId=465952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465952 ]
ASF GitHub Bot logged work on HIVE-23951: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Aug/20 23:30 Start Date: 03/Aug/20 23:30 Worklog Time Spent: 10m Work Description: vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464714632 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ########## @@ -1619,6 +1620,9 @@ public static ColStatistics getColStatisticsFromExpression(HiveConf conf, Statis colName = enfd.getFieldName(); colType = enfd.getTypeString(); countDistincts = numRows; + } else if (end instanceof ExprDynamicParamDesc) { + //skip colecting stats for parameters Review comment: This method tries to figure out column statistics involved in the given expression. I guess the stats are used by parent callers to do various estimation like map join, aggregate min/max. For dynamic expression stats are returned as null. I think it makes more sense to do what `buildColStatForConstant` is doing and return an estimation instead of null. I will update the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 465952) Time Spent: 1h 50m (was: 1h 40m) > Support parameterized queries in WHERE/HAVING clause > ---------------------------------------------------- > > Key: HIVE-23951 > URL: https://issues.apache.org/jira/browse/HIVE-23951 > Project: Hive > Issue Type: Sub-task > Components: Query Planning > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)