[
https://issues.apache.org/jira/browse/HIVE-23922?focusedWorklogId=469799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469799
]
ASF GitHub Bot logged work on HIVE-23922:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/20 16:44
Start Date: 12/Aug/20 16:44
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1307:
URL: https://github.com/apache/hive/pull/1307#discussion_r469396911
##########
File path: udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java
##########
@@ -65,16 +65,13 @@ public UDFArgumentException(String message,
Class<?> funcClass,
List<TypeInfo> argTypeInfos,
List<Method> methods) {
- super(getMessage(message, funcClass, argTypeInfos, methods));
+ super(getMessage(message, methods));
this.funcClass = funcClass;
this.argTypeInfos = argTypeInfos;
this.methods = methods;
}
-
- private static String getMessage(String message,
- Class<?> funcClass,
- List<TypeInfo> argTypeInfos,
- List<Method> methods) {
+ //HIVE-23896 remove unnecessary parameter
Review comment:
Could you please remove the comment and replace with a new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 469799)
Time Spent: 1h 20m (was: 1h 10m)
> Improve code quality, UDFArgumentException.getMessage Method requires only
> two parameters
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-23922
> URL: https://issues.apache.org/jira/browse/HIVE-23922
> Project: Hive
> Issue Type: Improvement
> Reporter: hao
> Assignee: hao
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [UDFArgumentException.getMessage] This method only needs two parameters,
> message and methods. The rest parameters are not used
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
