[
https://issues.apache.org/jira/browse/HIVE-23979?focusedWorklogId=470746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470746
]
ASF GitHub Bot logged work on HIVE-23979:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/20 16:23
Start Date: 14/Aug/20 16:23
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1404:
URL: https://github.com/apache/hive/pull/1404#discussion_r470726118
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -148,7 +148,7 @@ public static void setPerfLogger(PerfLogger
resetPerfLogger) {
* @param method method or ID that identifies this perf log element.
*/
@SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification =
"Intended")
Review comment:
Can this be removed now? Same for few methods below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 470746)
Time Spent: 20m (was: 10m)
> Resolve spotbugs errors in JsonReporter.java, Metrics.java, and
> PerfLogger.java
> -------------------------------------------------------------------------------
>
> Key: HIVE-23979
> URL: https://issues.apache.org/jira/browse/HIVE-23979
> Project: Hive
> Issue Type: Bug
> Reporter: Soumyakanti Das
> Assignee: Soumyakanti Das
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Resolve these spotbugs errors:
> [ERROR] Found reliance on default encoding in
> org.apache.hadoop.hive.metastore.metrics.JsonReporter.report(SortedMap,
> SortedMap, SortedMap, SortedMap, SortedMap): new java.io.FileWriter(File)
> [org.apache.hadoop.hive.metastore.metrics.JsonReporter] At
> JsonReporter.java:[line 159] DM_DEFAULT_ENCODING
> [ERROR] Incorrect lazy initialization of static field
> org.apache.hadoop.hive.metastore.metrics.Metrics.self in
> org.apache.hadoop.hive.metastore.metrics.Metrics.shutdown()
> [org.apache.hadoop.hive.metastore.metrics.Metrics] At Metrics.java:[lines
> 79-85] LI_LAZY_INIT_STATIC
> [ERROR] The method name
> org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogBegin(String,
> String) doesn't start with a lower case letter
> [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At
> PerfLogger.java:[lines 92-98] NM_METHOD_NAMING_CONVENTION
> [ERROR] The method name
> org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogEnd(String,
> String) doesn't start with a lower case letter
> [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At
> PerfLogger.java:[line 106] NM_METHOD_NAMING_CONVENTION
> [ERROR] The method name
> org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogEnd(String,
> String, String) doesn't start with a lower case letter
> [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At
> PerfLogger.java:[lines 116-138] NM_METHOD_NAMING_CONVENTION
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
