[
https://issues.apache.org/jira/browse/HIVE-24081?focusedWorklogId=476452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476452
]
ASF GitHub Bot logged work on HIVE-24081:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/20 08:59
Start Date: 31/Aug/20 08:59
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #1437:
URL: https://github.com/apache/hive/pull/1437#discussion_r479992802
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java
##########
@@ -457,4 +469,17 @@ public boolean hasTableDefined() {
return !(aliases.size() == 1 &&
aliases.get(0).equals(SemanticAnalyzer.DUMMY_TABLE));
}
+ public void addSubqExprAlias(ASTNode expressionTree, SemanticAnalyzer
semanticAnalyzer) throws SemanticException {
+ String alias = "__subexpr" + subQueryExpressionAliasCounter++;
+
+ // Recursively do the first phase of semantic analysis for the subquery
+ QBExpr qbexpr = new QBExpr(alias);
+
+ ASTNode subqref = (ASTNode) expressionTree.getChild(1);
+ semanticAnalyzer.doPhase1QBExpr(subqref, qbexpr, getId(), alias,
isInsideView());
Review comment:
This step parses the subquery only. It is necessary to collect
references to the CTEs in subquery expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 476452)
Time Spent: 50m (was: 40m)
> Enable pre-materializing CTEs referenced in scalar subqueries
> -------------------------------------------------------------
>
> Key: HIVE-24081
> URL: https://issues.apache.org/jira/browse/HIVE-24081
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HIVE-11752 introduces materializing CTE based on config
> {code}
> hive.optimize.cte.materialize.threshold
> {code}
> Goal of this jira is
> * extending the implementation to support materializing CTE's referenced in
> scalar subqueries
> * add a config to materialize CTEs with aggregate output only
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
