[
https://issues.apache.org/jira/browse/HIVE-23413?focusedWorklogId=479939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479939
]
ASF GitHub Bot logged work on HIVE-23413:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 08:51
Start Date: 08/Sep/20 08:51
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1220:
URL: https://github.com/apache/hive/pull/1220#discussion_r484757467
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite)
throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
+ public void testCheckExpectedLocks2NoReadLock() throws Exception {
+ testCheckExpectedLocks2(false);
+ }
+ public void testCheckExpectedLocks2(boolean readLocks) throws Exception {
Review comment:
nit: new row
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite)
throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
Review comment:
nit: new row
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 479939)
Time Spent: 50m (was: 40m)
> Create a new config to skip all locks
> -------------------------------------
>
> Key: HIVE-23413
> URL: https://issues.apache.org/jira/browse/HIVE-23413
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23413.1.patch, HIVE-23413.2.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> From time-to-time some query is blocked on locks which should not.
> To have a quick workaround for this we should have a config which the user
> can set in the session to disable acquiring/checking locks, so we can provide
> it immediately and then later investigate and fix the root cause.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
