[
https://issues.apache.org/jira/browse/HIVE-24154?focusedWorklogId=483631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483631
]
ASF GitHub Bot logged work on HIVE-24154:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/20 10:28
Start Date: 13/Sep/20 10:28
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1492:
URL: https://github.com/apache/hive/pull/1492#discussion_r487511233
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
##########
@@ -734,6 +721,30 @@ private RexNode useStructIfNeeded(List<? extends RexNode>
columns) {
}
operands.remove(i);
--i;
+ } else if (operand.getKind() == SqlKind.EQUALS) {
+ Constraint c = Constraint.of(operand);
+ if (c == null || !HiveCalciteUtil.isDeterministic(c.exprNode)) {
+ continue;
+ }
+ String ref = c.exprNode.toString();
+ stringToExpr.put(ref, c.exprNode);
+ if (inLHSExprToRHSExprs.containsKey(ref)) {
+ String expr = c.constNode.toString();
+ stringToExpr.put(expr, c.constNode);
Review comment:
note: we have RexNode-s are comparable; this string2expr stuff is not
neccessarily needed anymore
##########
File path:
ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query74.q.out
##########
@@ -147,7 +147,7 @@ HiveSortLimit(sort0=[$2], sort1=[$0], sort2=[$1],
dir0=[ASC], dir1=[ASC], dir2=[
HiveProject(ss_sold_date_sk=[$0],
ss_customer_sk=[$3], ss_net_paid=[$20])
HiveTableScan(table=[[default, store_sales]],
table:alias=[store_sales])
HiveProject(d_date_sk=[$0])
- HiveFilter(condition=[AND(=($1, 1999), IN($1, 1998,
1999))])
+ HiveFilter(condition=[=($1, 1999)])
Review comment:
I see that this patch works - but would have thinked that we didn't need
something like this anymore - because IN is opened in an early phase - so
Calcite should see a bunch of ANDs and ORs - and if that's true - RexSimplify
could make this simplification - and there would be no need to enhance
PointLookup...
I wonder how the IN was retained ...or re-created...
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
##########
@@ -599,7 +587,7 @@ public ConstraintGroup(RexNode rexNode) {
if (constraint == null) {
throw new SemanticException("Unable to find constraint which was
earlier added.");
}
- ret.add(constraint.exprNode);
+ ret.add(constraint.constNode);
Review comment:
oh my; Constrain had it's constructor arguments swapped! what a typo!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 483631)
Time Spent: 20m (was: 10m)
> Missing simplification opportunity with IN and EQUALS clauses
> -------------------------------------------------------------
>
> Key: HIVE-24154
> URL: https://issues.apache.org/jira/browse/HIVE-24154
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For instance, in perf driver CBO query 74, there are several filters that
> could be simplified further:
> {code}
> HiveFilter(condition=[AND(=($1, 1999), IN($1, 1998, 1999))])
> {code}
> This may lead to incorrect estimates and leads to unnecessary execution time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
