[
https://issues.apache.org/jira/browse/HIVE-23618?focusedWorklogId=488159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488159
]
ASF GitHub Bot logged work on HIVE-23618:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 10:53
Start Date: 22/Sep/20 10:53
Worklog Time Spent: 10m
Work Description: adesh-rao commented on a change in pull request #1237:
URL: https://github.com/apache/hive/pull/1237#discussion_r492640788
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -703,6 +709,49 @@ public void
onAddNotNullConstraint(AddNotNullConstraintEvent addNotNullConstrain
}
}
+ /***
+ * @param addDefaultConstraintEvent add default constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddDefaultConstraint(AddDefaultConstraintEvent
addDefaultConstraintEvent) throws MetaException {
+ List<SQLDefaultConstraint> cols =
addDefaultConstraintEvent.getDefaultConstraintCols();
+ if (cols.size() > 0) {
+ AddDefaultConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddDefaultConstraintMessage(addDefaultConstraintEvent.getDefaultConstraintCols());
Review comment:
done. Thought changed it to `colsInMsg`
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -3195,13 +3201,17 @@ public void testConstraints() throws IOException {
assertEquals(fks.size(), 2);
List<SQLNotNullConstraint> nns =
metaStoreClientMirror.getNotNullConstraints(new
NotNullConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl3"));
assertEquals(nns.size(), 1);
+ List<SQLCheckConstraint> cks =
metaStoreClientMirror.getCheckConstraints(new
CheckConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl7"));
+ assertEquals(cks.size(), 2);
} catch (TException te) {
assertNull(te);
}
run("CREATE TABLE " + dbName + ".tbl4(a string, b string, primary key (a,
b) disable novalidate rely)", driver);
run("CREATE TABLE " + dbName + ".tbl5(a string, b string, foreign key (a,
b) references " + dbName + ".tbl4(a, b) disable novalidate)", driver);
run("CREATE TABLE " + dbName + ".tbl6(a string, b string not null disable,
unique (a) disable)", driver);
+ run("CREATE TABLE " + dbName + ".tbl9(a string CHECK (a like 'a%'), price
double CHECK (price > 0 AND price <= 1000))", driver);
+ run("CREATE TABLE " + dbName + ".tbl10(a string, b int DEFAULT 0)",
driver);
Review comment:
Alter table can either add or drop the constraints. Since the drop was
already there, I have added add through alter too.
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -3195,13 +3201,17 @@ public void testConstraints() throws IOException {
assertEquals(fks.size(), 2);
List<SQLNotNullConstraint> nns =
metaStoreClientMirror.getNotNullConstraints(new
NotNullConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl3"));
assertEquals(nns.size(), 1);
+ List<SQLCheckConstraint> cks =
metaStoreClientMirror.getCheckConstraints(new
CheckConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl7"));
+ assertEquals(cks.size(), 2);
} catch (TException te) {
assertNull(te);
}
run("CREATE TABLE " + dbName + ".tbl4(a string, b string, primary key (a,
b) disable novalidate rely)", driver);
run("CREATE TABLE " + dbName + ".tbl5(a string, b string, foreign key (a,
b) references " + dbName + ".tbl4(a, b) disable novalidate)", driver);
run("CREATE TABLE " + dbName + ".tbl6(a string, b string not null disable,
unique (a) disable)", driver);
+ run("CREATE TABLE " + dbName + ".tbl9(a string CHECK (a like 'a%'), price
double CHECK (price > 0 AND price <= 1000))", driver);
+ run("CREATE TABLE " + dbName + ".tbl10(a string, b int DEFAULT 0)",
driver);
Review comment:
Alter table constraints hive doc:
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterTableConstraints
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -703,6 +709,49 @@ public void
onAddNotNullConstraint(AddNotNullConstraintEvent addNotNullConstrain
}
}
+ /***
+ * @param addDefaultConstraintEvent add default constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddDefaultConstraint(AddDefaultConstraintEvent
addDefaultConstraintEvent) throws MetaException {
+ List<SQLDefaultConstraint> cols =
addDefaultConstraintEvent.getDefaultConstraintCols();
+ if (cols.size() > 0) {
+ AddDefaultConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddDefaultConstraintMessage(addDefaultConstraintEvent.getDefaultConstraintCols());
+ NotificationEvent event =
+ new NotificationEvent(0, now(),
EventType.ADD_DEFAULTCONSTRAINT.toString(),
+ msgEncoder.getSerializer().serialize(msg)
+ );
+ event.setCatName(cols.get(0).isSetCatName() ? cols.get(0).getCatName() :
DEFAULT_CATALOG_NAME);
+ event.setDbName(cols.get(0).getTable_db());
+ event.setTableName(cols.get(0).getTable_name());
+ process(event, addDefaultConstraintEvent);
+ }
+ }
+
+ /***
+ * @param addCheckConstraintEvent add check constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddCheckConstraint(AddCheckConstraintEvent
addCheckConstraintEvent) throws MetaException {
+ LOG.info("Inside DBNotification listener for check constraint.");
+ List<SQLCheckConstraint> cols =
addCheckConstraintEvent.getCheckConstraintCols();
+ if (cols.size() > 0) {
+ AddCheckConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddCheckConstraintMessage(addCheckConstraintEvent.getCheckConstraintCols());
Review comment:
done as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 488159)
Time Spent: 1.5h (was: 1h 20m)
> NotificationLog should also contain events for default/check constraints
> ------------------------------------------------------------------------
>
> Key: HIVE-23618
> URL: https://issues.apache.org/jira/browse/HIVE-23618
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 4.0.0
> Reporter: Adesh Kumar Rao
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This should follow similar approach of notNull/Unique constraints. This will
> also include event replication for these constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
