[
https://issues.apache.org/jira/browse/HIVE-21375?focusedWorklogId=493068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493068
]
ASF GitHub Bot logged work on HIVE-21375:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/20 16:38
Start Date: 30/Sep/20 16:38
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1541:
URL: https://github.com/apache/hive/pull/1541#discussion_r497650656
##########
File path:
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
##########
@@ -1107,4 +1114,37 @@ private static void setHiveConf(HiveConf conf,
HiveConf.ConfVars var, boolean va
conf.setBoolVar(var, value);
}
+ private static void incRefForUgi(UserGroupInformation ugi) {
+ refCountLock.lock();
+ try {
+ Long prevCount = ugiConnectionRefCount.putIfAbsent(ugi, 1L);
+ if (prevCount != null) {
Review comment:
How can this be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 493068)
Time Spent: 0.5h (was: 20m)
> Closing TransactionBatch closes FileSystem for other batches in Hive
> streaming v1
> ---------------------------------------------------------------------------------
>
> Key: HIVE-21375
> URL: https://issues.apache.org/jira/browse/HIVE-21375
> Project: Hive
> Issue Type: Bug
> Components: HCatalog, Streaming
> Affects Versions: 3.2.0
> Reporter: Shawn Weeks
> Assignee: Ádám Szita
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The patch in HIVE-13151 added FileSystem.closeAllForUGI(ugi); to the close
> method of HiveEndPoint for the legacy Streaming API. This seems to have a
> side effect of closing the FileSystem for all open TransactionBatches as used
> by NiFi and Storm when writing to multiple partitions. Setting
> fs.hdfs.impl.disable.cache=true negates the issue but at a performance cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
