[ 
https://issues.apache.org/jira/browse/HIVE-24109?focusedWorklogId=503628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-503628
 ]

ASF GitHub Bot logged work on HIVE-24109:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Oct/20 08:52
            Start Date: 22/Oct/20 08:52
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #1529:
URL: https://github.com/apache/hive/pull/1529#discussion_r509991300



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -655,6 +643,11 @@ private static void populateLlapDaemonVarsSet(Set<String> 
llapDaemonVarsSetLocal
       "Provide the maximum number of partitions of a table that will be 
batched together during  \n"
         + "repl load. All the partitions in a batch will make a single 
metastore call to update the metadata. \n"
         + "The data for these partitions will be copied before copying the 
metadata batch. "),
+    
REPL_LOAD_PARTITIONS_WITH_DATA_COPY_BATCH_SIZE("hive.repl.load.partitions.with.data.copy.batch.size",
+      1000,

Review comment:
       It will increase the line length

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java
##########
@@ -270,10 +269,9 @@ static TableLocationTuple tableLocation(ImportTableDesc 
tblDesc, Database parent
     Path dataPath = fromURI;
     Path tmpPath = tgtPath;
 
-    // if move optimization is enabled, copy the files directly to the target 
path. No need to create the staging dir.
+    // if acid tables, copy the files directly to the target path. No need to 
create the staging dir.
     LoadFileType loadFileType;
-    if (replicationSpec.isInReplicationScope() &&
-            context.hiveConf.getBoolVar(REPL_ENABLE_MOVE_OPTIMIZATION)) {
+    if (replicationSpec.isInReplicationScope() && 
AcidUtils.isTransactionalTable(table)) {

Review comment:
       This is only for the ptests which use non acid managed tables.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 503628)
    Time Spent: 40m  (was: 0.5h)

> Load partitions in parallel for managed tables in the bootstrap phase
> ---------------------------------------------------------------------
>
>                 Key: HIVE-24109
>                 URL: https://issues.apache.org/jira/browse/HIVE-24109
>             Project: Hive
>          Issue Type: Task
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-24109.01.patch, HIVE-24109.02.patch, 
> HIVE-24109.03.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to