[ https://issues.apache.org/jira/browse/HIVE-24258?focusedWorklogId=504248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504248 ]
ASF GitHub Bot logged work on HIVE-24258: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Oct/20 16:52 Start Date: 23/Oct/20 16:52 Worklog Time Spent: 10m Work Description: ashish-kumar-sharma commented on a change in pull request #1587: URL: https://github.com/apache/hive/pull/1587#discussion_r511014101 ########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ########## @@ -2846,31 +2846,28 @@ public SQLAllTableConstraints getAllTableConstraints(String catName, String dbNa return sqlAllTableConstraints; } - @Override public List<String> createTableWithConstraints(Table tbl, List<SQLPrimaryKey> primaryKeys, - List<SQLForeignKey> foreignKeys, List<SQLUniqueConstraint> uniqueConstraints, - List<SQLNotNullConstraint> notNullConstraints, List<SQLDefaultConstraint> defaultConstraints, - List<SQLCheckConstraint> checkConstraints) throws InvalidObjectException, MetaException { - List<String> constraintNames = rawStore - .createTableWithConstraints(tbl, primaryKeys, foreignKeys, uniqueConstraints, notNullConstraints, - defaultConstraints, checkConstraints); + @Override public SQLAllTableConstraints createTableWithConstraints(Table tbl, SQLAllTableConstraints constraints) throws InvalidObjectException, MetaException { Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 504248) Time Spent: 1h 10m (was: 1h) > [CachedStore] Data miss match between cachedstore and rawstore > -------------------------------------------------------------- > > Key: HIVE-24258 > URL: https://issues.apache.org/jira/browse/HIVE-24258 > Project: Hive > Issue Type: Improvement > Reporter: Ashish Sharma > Assignee: Sankar Hariappan > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Description > Objects like table name, db name, column name etc are case insensitive as per > HIVE contract but standalone metastore cachedstore is case sensitive. As > result of which there is mismatch in rawstore output and cachedstore output. > Example - > expected:<[SQLPrimaryKey(table_db:test_table_ops, table_name:tbl, > column_name:col1, key_seq:1, pk_name:pk1, enable_cstr:false, > validate_cstr:false, rely_cstr:false, catName:hive)]> > but was:<[SQLPrimaryKey(table_db:test_table_ops, table_name:tbl, > column_name:col1, key_seq:1, pk_name:Pk1, enable_cstr:false, > validate_cstr:false, rely_cstr:false, catName:hive)]> -- This message was sent by Atlassian Jira (v8.3.4#803005)