[
https://issues.apache.org/jira/browse/HIVE-24475?focusedWorklogId=519633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-519633
]
ASF GitHub Bot logged work on HIVE-24475:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/20 13:24
Start Date: 03/Dec/20 13:24
Worklog Time Spent: 10m
Work Description: asinkovits commented on a change in pull request #1730:
URL: https://github.com/apache/hive/pull/1730#discussion_r535223946
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java
##########
@@ -243,6 +233,12 @@ public void testInvalidKeyIndex() throws Exception {
checkInvalidKeyIndex(testFilePath);
// Try fixing, this should result in new fixed file.
fixInvalidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new FaultyKeyIndexBuilder());
+ checkInvalidKeyIndex(testFilePath);
+ // Try fixing, this should result in new fixed file.
+ fixInvalidIndex(testFilePath);
Review comment:
There is a validation in the tool itself after the recovery, so if the
index was still invalid, the output would be different.
https://github.com/asinkovits/hive/blob/HIVE-24475/ql/src/java/org/apache/hadoop/hive/ql/io/orc/FixAcidKeyIndex.java#L265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 519633)
Time Spent: 0.5h (was: 20m)
> Generalize fixacidkeyindex utility
> ----------------------------------
>
> Key: HIVE-24475
> URL: https://issues.apache.org/jira/browse/HIVE-24475
> Project: Hive
> Issue Type: Improvement
> Components: ORC, Transactions
> Affects Versions: 3.0.0
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There is a utility in hive which can validate/fix corrupted
> hive.acid.key.index.
> hive --service fixacidkeyindex
> Unfortunately it is only tailored for a specific problem
> (https://issues.apache.org/jira/browse/HIVE-18907), instead of generally
> validating and recovering the hive.acid.key.index from the stripe data itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
