[
https://issues.apache.org/jira/browse/HIVE-24474?focusedWorklogId=523127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523127
]
ASF GitHub Bot logged work on HIVE-24474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/20 10:17
Start Date: 11/Dec/20 10:17
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r540839467
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -556,20 +544,20 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
verifyTableIdHasNotChanged(ci, t1);
LOG.info("Completed " + ci.type.toString() + " compaction for " +
ci.getFullPartitionName() + " in txn "
- + JavaUtils.txnIdToString(compactorTxnId) + ", marking as
compacted.");
+ + JavaUtils.txnIdToString(compactionTxn.getTxnId()) + ", marking
as compacted.");
Review comment:
Done
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -483,12 +471,12 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
* multiple statements in it (for query based compactor) which is not
supported (and since
* this case some of the statements are DDL, even in the future will not
be allowed in a
* multi-stmt txn. {@link Driver#setCompactionWriteIds(ValidWriteIdList,
long)} */
- compactorTxnId = msc.openTxn(ci.runAs, TxnType.COMPACTION);
+ compactionTxn.open(ci);
- heartbeater = new CompactionHeartbeater(compactorTxnId, fullTableName,
conf);
+ heartbeater = new CompactionHeartbeater(compactionTxn.getTxnId(),
fullTableName, conf);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 523127)
Time Spent: 1h 10m (was: 1h)
> Failed compaction always logs TxnAbortedException (again)
> ---------------------------------------------------------
>
> Key: HIVE-24474
> URL: https://issues.apache.org/jira/browse/HIVE-24474
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Re-introduced with HIVE-24096.
> If there is an error during compaction, the compaction's txn is aborted but
> in the finally clause, we try to commit it (commitTxnIfSet), so Worker throws
> a TxnAbortedException.
> We should set compactorTxnId to TXN_ID_NOT_SET if the compaction's txn is
> aborted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
