[
https://issues.apache.org/jira/browse/HIVE-24274?focusedWorklogId=523184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523184
]
ASF GitHub Bot logged work on HIVE-24274:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/20 13:14
Start Date: 11/Dec/20 13:14
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #1706:
URL: https://github.com/apache/hive/pull/1706#discussion_r540938046
##########
File path: ql/src/test/results/clientpositive/llap/avrotblsjoin.q.out
##########
@@ -73,6 +73,7 @@ POSTHOOK: Lineage: table1_1.col1 SCRIPT []
POSTHOOK: Lineage: table1_1.col2 SCRIPT []
WARNING: Comparing a bigint and a string may result in a loss of precision.
WARNING: Comparing a bigint and a string may result in a loss of precision.
+WARNING: Comparing a bigint and a string may result in a loss of precision.
Review comment:
It is a side effect of unparsing is enable for all queries.
When the calcite plan is generated `genJoinRelNode` is called and it calls
`genAllExprNodeDesc` because unparsing is enabled which is required for
expanded query text.
```
} else if (unparseTranslator != null &&
unparseTranslator.isEnabled()) {
genAllExprNodeDesc(joinCond, input, jCtx);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 523184)
Time Spent: 3h 20m (was: 3h 10m)
> Implement Query Text based MaterializedView rewrite
> ---------------------------------------------------
>
> Key: HIVE-24274
> URL: https://issues.apache.org/jira/browse/HIVE-24274
> Project: Hive
> Issue Type: Improvement
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Besides the way queries are currently rewritten to use materialized views in
> Hive this project provides an alternative:
> Compare the query text with the materialized views query text stored. If we
> found a match the original query's logical plan can be replaced by a scan on
> the materialized view.
> - Only materialized views which are enabled to rewrite can participate
> - Use existing *HiveMaterializedViewsRegistry* through *Hive* object by
> adding a lookup method by query text.
> - There might be more than one materialized views which have the same query
> text. In this case chose the first valid one.
> - Validation can be done by calling
> *Hive.validateMaterializedViewsFromRegistry()*
> - The scope of this first patch is rewriting queries which entire text can be
> matched only.
> - Use the expanded query text (fully qualified column and table names) for
> comparing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
