[
https://issues.apache.org/jira/browse/HIVE-24428?focusedWorklogId=523772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523772
]
ASF GitHub Bot logged work on HIVE-24428:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/20 09:36
Start Date: 14/Dec/20 09:36
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #1724:
URL: https://github.com/apache/hive/pull/1724#discussion_r542238768
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java
##########
@@ -747,6 +753,92 @@ private void checkFileFormats(Hive db, LoadTableDesc tbd,
Table table)
}
}
+ class LocalTableLock implements Closeable{
+
+ private Optional<HiveLockObject> lock;
+ private HiveLock lockObj;
+
+ public LocalTableLock(Optional<HiveLockObject> lock) throws LockException {
+
+ this.lock = lock;
+ if(!lock.isPresent()) {
+ return;
+ }
+ LOG.info("LocalTableLock; locking: " + lock);
+ HiveLockManager lockMgr = context.getHiveTxnManager().getLockManager();
+ lockObj = lockMgr.lock(lock.get(), HiveLockMode.SEMI_SHARED, true);
+ LOG.info("LocalTableLock; locked: " + lock);
+ }
+
+ @Override
+ public void close() throws IOException {
+ if(!lock.isPresent()) {
+ return;
+ }
+ LOG.info("LocalTableLock; unlocking: "+lock);
+ HiveLockManager lockMgr;
+ try {
+ lockMgr = context.getHiveTxnManager().getLockManager();
+ lockMgr.unlock(lockObj);
+ } catch (LockException e1) {
+ throw new IOException(e1);
+ }
+ LOG.info("LocalTableLock; unlocked");
+ }
+
+ }
+
+ private LocalTableLock acquireLockForFileMove(LoadTableDesc loadTableWork)
throws HiveException {
+ // nothing needs to be done
+ if (!conf.getBoolVar(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY)) {
+ return new LocalTableLock(Optional.empty());
+ }
+ String lockFileMoveMode =
conf.getVar(HiveConf.ConfVars.HIVE_LOCK_FILE_MOVE_MODE);
+
+ if ("none".equalsIgnoreCase(lockFileMoveMode)) {
Review comment:
Yes, I think, having enum in MoveTask should be ok. Btw, should we
allow to modify HIVE_LOCK_FILE_MOVE_MODE in runtime, if not, we can init this
enum in constructor or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 523772)
Time Spent: 50m (was: 40m)
> Concurrent add_partitions requests may lead to data loss
> --------------------------------------------------------
>
> Key: HIVE-24428
> URL: https://issues.apache.org/jira/browse/HIVE-24428
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> in case multiple clients are adding partitions to the same table - when the
> same partition is being added there is a chance that the data dir is removed
> after the other client have already written its data
> https://github.com/apache/hive/blob/5e96b14a2357c66a0640254d5414bc706d8be852/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L3958
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
