[ https://issues.apache.org/jira/browse/HIVE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941485#comment-14941485 ]
Hive QA commented on HIVE-9447: ------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12764509/HIVE-9447.2.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5499/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5499/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5499/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-5499/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive ff9822e..a1bac80 master -> origin/master + git reset --hard HEAD HEAD is now at ff9822e HIVE-12004 : SDPO doesnt set colExprMap correctly on new RS (Ashutosh Chauhan via Prasanth J) + git clean -f -d + git checkout master Already on 'master' Your branch is behind 'origin/master' by 2 commits, and can be fast-forwarded. + git reset --hard origin/master HEAD is now at a1bac80 HIVE-11998 - Improve Compaction process logging (Eugene Koifman, reviewed by Jason Dere) + git merge --ff-only origin/master Already up-to-date. + git gc + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12764509 - PreCommit-HIVE-TRUNK-Build > Metastore: inefficient Oracle query for removing unused column descriptors > when add/drop table/partition > -------------------------------------------------------------------------------------------------------- > > Key: HIVE-9447 > URL: https://issues.apache.org/jira/browse/HIVE-9447 > Project: Hive > Issue Type: Improvement > Components: Metastore > Affects Versions: 0.14.0 > Reporter: Selina Zhang > Assignee: Selina Zhang > Attachments: HIVE-9447.1.patch, HIVE-9447.2.patch > > Original Estimate: 3h > Remaining Estimate: 3h > > Metastore needs removing unused column descriptors when drop/add partitions > or tables. For query the unused column descriptor, the current implementation > utilizes datanuleus' range function, which basically equals LIMIT syntax. > However, Oracle does not support LIMIT, the query is converted as > {quote} > SQL> SELECT * FROM (SELECT subq.*,ROWNUM rn FROM (SELECT > 'org.apache.hadoop.hive.metastore.model.MStorageDescriptor' AS > NUCLEUS_TYPE,A0.INPUT_FORMAT,A0.IS_COMPRESSED,A0.IS_STOREDASSUBDIRECTORIES,A0.LOCATION, > A0.NUM_BUCKETS,A0.OUTPUT_FORMAT,A0.SD_ID FROM drhcat.SDS A0 > WHERE A0.CD_ID = ? ) subq ) WHERE rn <= 1; > {quote} > Given that CD_ID is not very selective, this query may have to access large > amount of rows (depends how many partitions the table has, millions of rows > in our case). Metastore may become unresponsive because of this. > Since Metastore only needs to know if the specific CD_ID is referenced in SDS > table and does not need access the whole row. We can use > {quote} > select count(1) from SDS where SDS.CD_ID=? > {quote} > CD_ID is index column, the above query will do range scan for index, which is > faster. > For other DBs support LIMIT syntax such as MySQL, this problem does not > exist. However, the new query does not hurt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)