[
https://issues.apache.org/jira/browse/HIVE-24511?focusedWorklogId=527036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527036
]
ASF GitHub Bot logged work on HIVE-24511:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 03:08
Start Date: 22/Dec/20 03:08
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1757:
URL: https://github.com/apache/hive/pull/1757#discussion_r547042025
##########
File path:
metastore/src/java/org/apache/hadoop/hive/metastore/SerDeStorageSchemaReader.java
##########
@@ -47,10 +48,10 @@
Deserializer s = HiveMetaStoreUtils.getDeserializer(conf, tbl, false);
return HiveMetaStoreUtils.getFieldsFromDeserializer(tbl.getTableName(),
s);
} catch (Exception e) {
- StringUtils.stringifyException(e);
- throw new MetaException(e.getMessage());
+ throw new MetaException(StringUtils.stringifyException(e));
Review comment:
If the serde of the table is not a part of
`metastore.serdes.using.metastore.for.schema`, like JsonSerDe(openx).
MetaStore will use the defined serde to get the columns of the table. It's may
be better to tell the caller that the exception happens when retrieving the
columns from serde other than return null or an empty list, so the
GetColumnsOperation can bring the exception to the front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 527036)
Time Spent: 0.5h (was: 20m)
> Fix typo in SerDeStorageSchemaReader
> ------------------------------------
>
> Key: HIVE-24511
> URL: https://issues.apache.org/jira/browse/HIVE-24511
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> 1, Close the created classloader to release resources.
> 2, More detail error messages on MetaException when throwing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
