[
https://issues.apache.org/jira/browse/HIVE-24509?focusedWorklogId=530300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530300
]
ASF GitHub Bot logged work on HIVE-24509:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/21 22:44
Start Date: 02/Jan/21 22:44
Worklog Time Spent: 10m
Work Description: miklosgergely edited a comment on pull request #1756:
URL: https://github.com/apache/hive/pull/1756#issuecomment-753538962
@belugabehr I've fixed most of the issues that you've mentioned. I was
mainly focused on putting the code to it's proper location, in a manageable
structure, and it was great that you've looked at the code thoroughly, finding
these suboptimal solutions, thank you for that.
Regarding the append().append() like issues: these commands are not
performance critical (it is not realistic that someone would like to issue 100s
of show / desc commands per sec), so in these cases I choose code readability
over performance. Still I've fixed those where LINE_DELIM is appended, as it
doesn't decrease readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530300)
Time Spent: 6h (was: 5h 50m)
> Move show specific codes under DDL and cut MetaDataFormatter classes to pieces
> ------------------------------------------------------------------------------
>
> Key: HIVE-24509
> URL: https://issues.apache.org/jira/browse/HIVE-24509
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Lot of show ... specific codes are under the
> org.apache.hadoop.hive.ql.metadata.formatting package which are used only by
> these commands. Also the two MetaDataFormatters (JsonMetaDataFormatter,
> TextMetaDataFormatter) are trying to do everything, while they contain a lot
> of code duplications. Their functionalities should be put under the
> directories of the appropriate show commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
