[
https://issues.apache.org/jira/browse/HIVE-24434?focusedWorklogId=530505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530505
]
ASF GitHub Bot logged work on HIVE-24434:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 03:53
Start Date: 04/Jan/21 03:53
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #1782:
URL: https://github.com/apache/hive/pull/1782#discussion_r551107074
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -1831,7 +1832,8 @@ public RelOptMaterialization
getMaterializedViewForRebuild(String dbName, String
private List<RelOptMaterialization> getValidMaterializedViews(List<Table>
materializedViewTables,
List<String> tablesUsed, boolean forceMVContentsUpToDate, boolean
expandGroupingSets,
- HiveTxnManager txnMgr) throws HiveException {
+ HiveTxnManager txnMgr,
EnumSet<org.apache.hadoop.hive.ql.metadata.Materialization.RewriteAlgorithm>
scope)
Review comment:
We already have a `Materialization` class so renamed this one to
`HiveRelOptMaterialization` which fixed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 530505)
Time Spent: 50m (was: 40m)
> Filter out materialized views for rewriting if plan pattern is not allowed
> --------------------------------------------------------------------------
>
> Key: HIVE-24434
> URL: https://issues.apache.org/jira/browse/HIVE-24434
> Project: Hive
> Issue Type: Improvement
> Components: Materialized views
> Affects Versions: 4.0.0
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some materialized views are not enabled for Calcite based rewriting. Rules
> for validating materialized views are implemented by HIVE-20748.
> Since text based materialized view query rewrite doesn't have such
> limitations some logic must be implemented to flag materialized view whether
> they are enabled to text based rewrite only or both.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
