[
https://issues.apache.org/jira/browse/HIVE-24386?focusedWorklogId=531369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531369
]
ASF GitHub Bot logged work on HIVE-24386:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/21 17:28
Start Date: 05/Jan/21 17:28
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #1694:
URL: https://github.com/apache/hive/pull/1694#discussion_r552081081
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/GetPartitionsRequestBuilder.java
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.client.builder;
+
+import org.apache.hadoop.hive.metastore.api.GetPartitionsFilterSpec;
+import org.apache.hadoop.hive.metastore.api.GetPartitionsRequest;
+import org.apache.hadoop.hive.metastore.api.GetProjectionsSpec;
+
+import java.util.List;
+
+public class GetPartitionsRequestBuilder {
+ private String catName = null;
+ private String dbName = null;
+ private String tblName = null;
+ private boolean withAuth = true;
+ private String user = null;
+ private List<String> groupNames = null;
+ private GetProjectionsSpec projectionSpec = null;
+ private GetPartitionsFilterSpec filterSpec = null;
+ private List<java.lang.String> processorCapabilities = null;
+ private String processorIdentifier = null;
+ private String validWriteIdList = null;
+
+ public GetPartitionsRequestBuilder(String catName, String dbName, String
tblName, boolean withAuth, String user,
+ List<String> groupNames,
GetProjectionsSpec projectionSpec,
+ GetPartitionsFilterSpec filterSpec,
List<String> processorCapabilities,
+ String processorIdentifier, String
validWriteIdList) {
+ this.catName = catName;
+ this.dbName = dbName;
+ this.tblName = tblName;
+ this.withAuth = withAuth;
+ this.user = user;
+ this.groupNames = groupNames;
+ this.projectionSpec = projectionSpec;
+ this.filterSpec = filterSpec;
+ this.processorCapabilities = processorCapabilities;
Review comment:
the processorCapabilities and the processorIdentifier are meant to be
static values for a given instance of HMSClient object. They are not meant to
change between different calls. So having it on builder class might be
confusing. Should we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 531369)
Time Spent: 0.5h (was: 20m)
> Add builder methods for GetTablesRequest and GetPartitionsRequest to
> HiveMetaStoreClient
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-24386
> URL: https://issues.apache.org/jira/browse/HIVE-24386
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Builder methods for GetTablesRequest and GetPartitionsRequest should be added
> to the HiveMetaStoreClient class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
