[
https://issues.apache.org/jira/browse/HIVE-24591?focusedWorklogId=534454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534454
]
ASF GitHub Bot logged work on HIVE-24591:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/21 19:10
Start Date: 11/Jan/21 19:10
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #1833:
URL: https://github.com/apache/hive/pull/1833#discussion_r555273362
##########
File path: bin/ext/cli.sh
##########
@@ -28,7 +28,7 @@ updateCli() {
CLASS=org.apache.hadoop.hive.cli.CliDriver
JAR=hive-cli-*.jar
else
- export HADOOP_CLIENT_OPTS=" -Dproc_beeline $HADOOP_CLIENT_OPTS
-Dlog4j.configurationFile=beeline-log4j2.properties"
+ export HADOOP_CLIENT_OPTS="-Dproc_beeline
-Dorg.slf4j.simpleLogger.defaultLogLevel=warn $HADOOP_CLIENT_OPTS"
Review comment:
dumb question? how would users enable debug logging in beeline with this
approach ?
##########
File path: beeline/pom.xml
##########
@@ -105,19 +117,40 @@
<artifactId>super-csv</artifactId>
<version>${super-csv.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
Review comment:
arent we already using slf4j libraries in beeline today? How has this
been compiling without explicit dependencies? transitive?
also we should specify a scope for these dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 534454)
Time Spent: 40m (was: 0.5h)
> Move Beeline To SLF4J Simple Logger
> -----------------------------------
>
> Key: HIVE-24591
> URL: https://issues.apache.org/jira/browse/HIVE-24591
> Project: Hive
> Issue Type: Improvement
> Components: Beeline
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> To make beeline as simple as possible, move its SLF4J logger implementation
> to SLFJ-Simple logger. This will allow users to change the logging level
> simply on the command line. Currently uses must create a Log4J configuration
> file which is way too advance/cumbersome for a data analyst that just wants
> to use SQL (and do some minor troubleshooting)
> {code:none}
> export HADOOP_CLIENT_OPTS="-Dorg.slf4j.simpleLogger.defaultLogLevel=debug"
> beeline ...
> {code}
> http://www.slf4j.org/api/org/slf4j/impl/SimpleLogger.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
