[
https://issues.apache.org/jira/browse/HIVE-24534?focusedWorklogId=537322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537322
]
ASF GitHub Bot logged work on HIVE-24534:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/21 10:28
Start Date: 18/Jan/21 10:28
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1780:
URL: https://github.com/apache/hive/pull/1780#discussion_r559458095
##########
File path: ql/src/test/results/clientpositive/llap/avrotblsjoin.q.out
##########
@@ -71,9 +71,9 @@ POSTHOOK: Input: _dummy_database@_dummy_table
POSTHOOK: Output: default@table1_1
POSTHOOK: Lineage: table1_1.col1 SCRIPT []
POSTHOOK: Lineage: table1_1.col2 SCRIPT []
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
+WARNING: Comparing string and bigint may result in loss of information.
Review comment:
Maybe `a loss of precision` is more user friendly compared to
`information`.
##########
File path:
ql/src/test/results/clientpositive/llap/partition_wise_fileformat2.q.out
##########
@@ -123,31 +123,6 @@ POSTHOOK: Input: default@partition_test_partitioned@dt=102
100
100
100
-238 val_238 102
Review comment:
the result of this qfile seems unrelated to the changes...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 537322)
Time Spent: 1h 50m (was: 1h 40m)
> Prevent comparisons between characters and decimals types when strict checks
> enabled
> ------------------------------------------------------------------------------------
>
> Key: HIVE-24534
> URL: https://issues.apache.org/jira/browse/HIVE-24534
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> When we compare decimal and character types implicit conversions take place
> that can lead to unexpected and surprising results.
> {code:sql}
> create table t_str (str_col string);
> insert into t_str values ('1208925742523269458163819');select * from t_str
> where str_col=1208925742523269479013976;
> {code}
> The SELECT query brings up one row while the filtering value is not the same
> with the one present in the string column of the table. The problem is that
> both types are converted to doubles and due to loss of precision the values
> are deemed equal.
> Even if we change the implicit conversion to use another type (HIVE-24528)
> there are always some cases that may lead to unexpected results.
> The goal of this issue is to prevent comparisons between decimal and
> character types when hive.strict.checks.type.safety is enabled and throw an
> error.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
