[ https://issues.apache.org/jira/browse/HIVE-23553?focusedWorklogId=545304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545304 ]
ASF GitHub Bot logged work on HIVE-23553: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Feb/21 12:51 Start Date: 01/Feb/21 12:51 Worklog Time Spent: 10m Work Description: pgaref commented on a change in pull request #1823: URL: https://github.com/apache/hive/pull/1823#discussion_r567800512 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java ########## @@ -82,8 +82,7 @@ public void put(Path path, OrcTail tail) { if (bb.capacity() != bb.remaining()) { throw new RuntimeException("Bytebuffer allocated for path: " + path + " has remaining: " + bb.remaining() + " != capacity: " + bb.capacity()); } - cache.put(path, new TailAndFileData(tail.getFileTail().getFileLength(), - tail.getFileModificationTime(), bb.duplicate())); + cache.put(path, new TailAndFileData(bb.limit(), tail.getFileModificationTime(), bb.duplicate())); Review comment: But I agree, cache should be populated with the original **getFileTail().getFileLength()** as it is afterward used for comparison (thus reverted this change) -- however, where ReaderImpl.extractFileTail is now called uses the buffer size instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 545304) Time Spent: 5h 40m (was: 5.5h) > Upgrade ORC version to 1.6.7 > ---------------------------- > > Key: HIVE-23553 > URL: https://issues.apache.org/jira/browse/HIVE-23553 > Project: Hive > Issue Type: Improvement > Reporter: Panagiotis Garefalakis > Assignee: Panagiotis Garefalakis > Priority: Major > Labels: pull-request-available > Time Spent: 5h 40m > Remaining Estimate: 0h > > Apache Hive is currently on 1.5.X version and in order to take advantage of > the latest ORC improvements such as column encryption we have to bump to > 1.6.X. > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343288&styleName=&projectId=12318320&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED_4ae78f19321c7fb1e7f337fba1dd90af751d8810_lin > Even though ORC reader could work out of the box, HIVE LLAP is heavily > depending on internal ORC APIs e.g., to retrieve and store File Footers, > Tails, streams – un/compress RG data etc. As there ware many internal changes > from 1.5 to 1.6 (Input stream offsets, relative BufferChunks etc.) the > upgrade is not straightforward. > This Umbrella Jira tracks this upgrade effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)