[
https://issues.apache.org/jira/browse/HIVE-24673?focusedWorklogId=546046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-546046
]
ASF GitHub Bot logged work on HIVE-24673:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/21 14:13
Start Date: 02/Feb/21 14:13
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1902:
URL: https://github.com/apache/hive/pull/1902#discussion_r568632109
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -348,13 +348,13 @@ public CompareCliConfig() {
}
}
- public static class NegativeCliConfig extends AbstractCliConfig {
- public NegativeCliConfig() {
+ public static class NegativeLlapLocalCliConfig extends AbstractCliConfig {
Review comment:
after this patch we will have the following llap tests:
* TestMiniLlapLocalCliDriver
* TestNegativeLlapLocalCliDriver
* TestMiniLlapCliDriver
* TestNegativeLlapCliDriver
I'm just saying that instead of adding keywords to the test name we could
remove some...nowadays `TestMiniLlapLocalCliDriver` means the same to me as
what `TestCliDriver` have been a few years ago
Another interesting thing is the presence of the "Mini" in the name of some
of the llap drivers....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 546046)
Time Spent: 3h (was: 2h 50m)
> Migrate NegativeCliDriver and NegativeMinimrCliDriver to llap
> -------------------------------------------------------------
>
> Key: HIVE-24673
> URL: https://issues.apache.org/jira/browse/HIVE-24673
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> These test drivers should run on llap. Otherwise we can run into situations
> where certain queries correctly fail on MapReduce but not on Tez.
> Also, it is better if negative cli drivers does not mask "Caused by" lines in
> test output. Otherwise, a query may start to fail for other reasons than the
> expected one and we do not realize it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
