[
https://issues.apache.org/jira/browse/HIVE-24744?focusedWorklogId=549411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549411
]
ASF GitHub Bot logged work on HIVE-24744:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/21 06:59
Start Date: 08/Feb/21 06:59
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1949:
URL: https://github.com/apache/hive/pull/1949#discussion_r571816388
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -311,8 +311,11 @@ private void prepareReturnValues(List<String> values)
throws SemanticException {
}
private void deleteAllPreviousDumpMeta(Path currentDumpPath) {
+ Path dumpRoot = getDumpRoot(currentDumpPath);
Review comment:
Do it inside the try catch block. replication shouldn't fail if
getDumpRoot throws exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 549411)
Time Spent: 20m (was: 10m)
> Deletion of previous dump dir fails with NPE for ptests
> -------------------------------------------------------
>
> Key: HIVE-24744
> URL: https://issues.apache.org/jira/browse/HIVE-24744
> Project: Hive
> Issue Type: Bug
> Reporter: Arko Sharma
> Assignee: Arko Sharma
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24744.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
