[
https://issues.apache.org/jira/browse/HIVE-23882?focusedWorklogId=554369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554369
]
ASF GitHub Bot logged work on HIVE-23882:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 18:04
Start Date: 18/Feb/21 18:04
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1286:
URL: https://github.com/apache/hive/pull/1286#discussion_r578636105
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
##########
@@ -1589,13 +1588,17 @@ private void
removeSemijoinsParallelToMapJoin(OptimizeTezProcContext procCtx)
List<ExprNodeDesc> keyDesc =
selectedMJOp.getConf().getKeys().get(posBigTable);
ExprNodeColumnDesc keyCol = (ExprNodeColumnDesc) keyDesc.get(0);
- String realTSColName = OperatorUtils.findTableColNameOf(selectedMJOp,
keyCol.getColumn());
- if (realTSColName != null) {
+ ExprNodeColumnDesc originTSColExpr =
OperatorUtils.findTableOriginColExpr(keyCol, selectedMJOp, tsOp);
+ if (originTSColExpr == null) {
+ LOG.warn("ProbeDecode could not find origTSCol for mjCol: {} with MJ
Schema: {}",
Review comment:
Yeah, always had this in the back of my head. Opened HIVE-24793 to track
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554369)
Time Spent: 2h 50m (was: 2h 40m)
> Compiler should skip MJ keyExpr for probe optimization
> ------------------------------------------------------
>
> Key: HIVE-23882
> URL: https://issues.apache.org/jira/browse/HIVE-23882
> Project: Hive
> Issue Type: Sub-task
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In probe we cannot currently support Key expressions (on the big table Side)
> as ORC CVs Probe directly the smalltable HT (there is no expr evaluation at
> that level).
> TezCompiler should take this into account when picking MJs to push probe
> details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
