[
https://issues.apache.org/jira/browse/HIVE-24867?focusedWorklogId=564542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564542
]
ASF GitHub Bot logged work on HIVE-24867:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/21 11:53
Start Date: 11/Mar/21 11:53
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2058:
URL: https://github.com/apache/hive/pull/2058#discussion_r592297779
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergFilterFactory.java
##########
@@ -190,6 +190,7 @@ private static int daysFromTimestamp(Timestamp timestamp) {
// We have to use the LocalDateTime to get the micros. See the comment above.
private static long microsFromTimestamp(Timestamp timestamp) {
//
`org.apache.hadoop.hive.common.type.Timestamp.valueOf(lit.toString()).toSqlTimestamp()`
+ // since HIVE-21862 changes literal parsing to UTC based timestamps
Review comment:
The comment in this form does not make sense to me 😢
Either:
```
// HIVE-21862 changes literal parsing to UTC based timestamps to this:
//
`org.apache.hadoop.hive.common.type.Timestamp.valueOf(lit.toString()).toSqlTimestamp()`
```
Or just remove the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 564542)
Time Spent: 1h 40m (was: 1.5h)
> Create iceberg-handler module in Hive
> -------------------------------------
>
> Key: HIVE-24867
> URL: https://issues.apache.org/jira/browse/HIVE-24867
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> * Create a new iceberg-handler module in Hive
> * Copy the code from the Iceberg/iceberg-mr module into this new Hive module
> * Make necessary changes so it compiles with Hive 4.0.0 dependencies
> (iceberg-mr code was based on Hive 3.1)
> * Make sure all tests pass
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
