[ 
https://issues.apache.org/jira/browse/HIVE-24900?focusedWorklogId=569744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569744
 ]

ASF GitHub Bot logged work on HIVE-24900:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Mar/21 14:26
            Start Date: 22/Mar/21 14:26
    Worklog Time Spent: 10m 
      Work Description: klcopp commented on a change in pull request #2086:
URL: https://github.com/apache/hive/pull/2086#discussion_r598763036



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -555,6 +559,11 @@ protected Boolean findNextCompactionAndExecute(boolean 
computeStats) throws Inte
         LOG.error("Caught exception while trying to compact " + ci +
             ".  Marking failed to avoid repeated failures", e);
         markFailed(ci, e);
+        // remove the new directories created by compaction
+        if (resultDir != null) {
+          FileSystem fs = resultDir.getFileSystem(conf);
+          fs.delete(resultDir, true);

Review comment:
       Better: catch FileNotFoundExceptions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 569744)
    Time Spent: 1.5h  (was: 1h 20m)

> Failed compaction does not cleanup the directories
> --------------------------------------------------
>
>                 Key: HIVE-24900
>                 URL: https://issues.apache.org/jira/browse/HIVE-24900
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Ramesh Kumar Thangarajan
>            Assignee: Ramesh Kumar Thangarajan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Failed compaction does not cleanup the directories



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to