[ https://issues.apache.org/jira/browse/HIVE-23820?focusedWorklogId=577870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-577870 ]
ASF GitHub Bot logged work on HIVE-23820: ----------------------------------------- Author: ASF GitHub Bot Created on: 06/Apr/21 20:25 Start Date: 06/Apr/21 20:25 Worklog Time Spent: 10m Work Description: kishendas commented on a change in pull request #2153: URL: https://github.com/apache/hive/pull/2153#discussion_r608153724 ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ########## @@ -2367,10 +2367,21 @@ public Table getTable(String catName, String dbName, String tableName, return getTable(catName, dbName, tableName, validWriteIdList, false, null); } + @Override + public Table getTable(String catName, String dbName, String tableName, Review comment: It makes sense to just use GetTableResult get_table_req(1:GetTableRequest req) throws (1:MetaException o1, 2:NoSuchObjectException o2) and redirect all the other variations to use this method, so that you don't have to add tableId in all the other variations. Ideally we should deprecate and remove all the methods that doesn't take Request object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 577870) Time Spent: 20m (was: 10m) > [HS2] Send tableId in request for get_table_request API > ------------------------------------------------------- > > Key: HIVE-23820 > URL: https://issues.apache.org/jira/browse/HIVE-23820 > Project: Hive > Issue Type: Sub-task > Reporter: Kishen Das > Assignee: Ashish Sharma > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)