[
https://issues.apache.org/jira/browse/HIVE-24978?focusedWorklogId=579868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579868
]
ASF GitHub Bot logged work on HIVE-24978:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/21 09:43
Start Date: 09/Apr/21 09:43
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #2154:
URL: https://github.com/apache/hive/pull/2154#discussion_r609321577
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
##########
@@ -45,6 +45,14 @@ public DropPartitionEvent (Table table,
this.deleteData = deleteData;
}
+ public DropPartitionEvent(Table table, Iterable<Partition> partition,
boolean status, boolean deleteData,
+ IHMSHandler handler) {
+ super(status, handler);
+ this.table = table;
+ this.partitions = partition;
Review comment:
rename to partitions
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionOperation.java
##########
@@ -120,6 +126,12 @@ private void dropPartitions() throws HiveException {
List<Partition> droppedPartitions =
context.getDb().dropPartitions(tablenName.getDb(), tablenName.getTable(),
partitionExpressions, options);
+ if (isRepl) {
Review comment:
what is this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 579868)
Time Spent: 20m (was: 10m)
> Optimise number of DROP_PARTITION events created.
> -------------------------------------------------
>
> Key: HIVE-24978
> URL: https://issues.apache.org/jira/browse/HIVE-24978
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Presently there is one event for every drop, optimise to merge them, to save
> the number of calls to HMS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
