[
https://issues.apache.org/jira/browse/HIVE-24958?focusedWorklogId=579891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579891
]
ASF GitHub Bot logged work on HIVE-24958:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/21 10:36
Start Date: 09/Apr/21 10:36
Worklog Time Spent: 10m
Work Description: marton-bod edited a comment on pull request #2138:
URL: https://github.com/apache/hive/pull/2138#issuecomment-816589194
> Generally looks good to me.
> A few nits only. Did we remove all the "hacks" we did for the
iceberg-handler module which were needed until we have the metastore module?
Thanks for the review! Yes, the only hack we could remove with this one was
this:
https://github.com/apache/hive/pull/2138/files#diff-9d31f72cca8ab08ae120d321c1b58816336936a23a4ef720ad65e79d3acbe743L357
(and also the removal of `TestHiveMetastore` from the handler module)
Most other hacks depend on Iceberg 0.12.0 coming out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 579891)
Time Spent: 40m (was: 0.5h)
> Create Iceberg catalog module in Hive
> -------------------------------------
>
> Key: HIVE-24958
> URL: https://issues.apache.org/jira/browse/HIVE-24958
> Project: Hive
> Issue Type: Task
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> * Create a new iceberg-catalog module in Hive, with the code currently
> contained in Iceberg's iceberg-hive-metastore module
> * Make sure all tests pass (including static analysis and checkstyle)
> * Make iceberg-handler depend on this module instead ofÂ
> iceberg-hive-metastore
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
