[ 
https://issues.apache.org/jira/browse/HIVE-25065?focusedWorklogId=590339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590339
 ]

ASF GitHub Bot logged work on HIVE-25065:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Apr/21 12:36
            Start Date: 28/Apr/21 12:36
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on a change in pull request #2230:
URL: https://github.com/apache/hive/pull/2230#discussion_r622134869



##########
File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java
##########
@@ -48,6 +48,9 @@
   public List<String> allowedAlterTypes = ImmutableList.of("ADDPROPS", 
"DROPPROPS");
   String ALTERLOCATION = "ALTERLOCATION";
   String ALLOW_PARTITION_KEY_CHANGE = "allow_partition_key_change";
+  String SET_PROPERTIES = "set_properties";
+  String UNSET_PROPERTIES = "unset_properties";
+  String PROPERTIES_SEPARATOR = "\n";

Review comment:
       Not sure which characters are unsupported in a key, but I think ' might 
work better as a separator due to the rules of the query language (since ' is 
used to mark the end of the table props in the SQL, e.g. 'key'='value')




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 590339)
    Time Spent: 40m  (was: 0.5h)

> Implement ALTER TABLE for setting iceberg table properties
> ----------------------------------------------------------
>
>                 Key: HIVE-25065
>                 URL: https://issues.apache.org/jira/browse/HIVE-25065
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently, only the Iceberg -> HMS table property synchronization is 
> implemented.
> We would like to make sure that {{ALTER TABLE SET TBLPROPERTIES()}} will 
> update the Iceberg table properties as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to