[
https://issues.apache.org/jira/browse/HIVE-24924?focusedWorklogId=597471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597471
]
ASF GitHub Bot logged work on HIVE-24924:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 06:29
Start Date: 17/May/21 06:29
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2105:
URL: https://github.com/apache/hive/pull/2105#discussion_r633253228
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java
##########
@@ -53,17 +53,6 @@ public int execute() {
String tableName = work.getTableName();
ReplicationSpec replicationSpec = work.getReplicationSpec();
if ((tableName != null) && (replicationSpec != null)) {
- Table tbl;
Review comment:
This is checking the replacement info from the table below -
```
tbl = Hive.get().getTable(work.getDbName(), tableName);
if (!replicationSpec.allowReplacementInto(tbl.getParameters())) {
```
But we don't track at table level now, so removed it. Earlier logic was if
the table is not found in the catch block it use to check at db level
```
} catch (InvalidTableException e) {
// In scenarios like import to mm tables, the alloc write id event
is generated before create table event.
try {
Database database = Hive.get().getDatabase(work.getDbName());
if
(!replicationSpec.allowReplacementInto(database.getParameters())) {
```
So, I have kept it to check always at database level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 597471)
Time Spent: 0.5h (was: 20m)
> Optimize checkpointing flow in incremental load
> -----------------------------------------------
>
> Key: HIVE-24924
> URL: https://issues.apache.org/jira/browse/HIVE-24924
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Attempt reducing alter calls for checkpointing during repl load
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
