[ 
https://issues.apache.org/jira/browse/HIVE-25034?focusedWorklogId=597587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597587
 ]

ASF GitHub Bot logged work on HIVE-25034:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/21 12:25
            Start Date: 17/May/21 12:25
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2243:
URL: https://github.com/apache/hive/pull/2243#discussion_r633483880



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -138,6 +148,17 @@ public void initialize(@Nullable Configuration 
configuration, Properties serDePr
     }
   }
 
+  private void createTableForCTAS(Configuration configuration, Properties 
serDeProperties) {
+    serDeProperties.setProperty(TableProperties.ENGINE_HIVE_ENABLED, "true");
+    serDeProperties.setProperty(InputFormatConfig.TABLE_SCHEMA, 
SchemaParser.toJson(tableSchema));
+    Catalogs.createTable(configuration, serDeProperties);
+    // set these in the global conf so that we can rollback the table in the 
lifecycle hook in case of failures

Review comment:
       A good candidate to put something into `QueryInfo`, or somewhere else




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 597587)
    Remaining Estimate: 0h
            Time Spent: 10m

> Implement CTAS for Iceberg
> --------------------------
>
>                 Key: HIVE-25034
>                 URL: https://issues.apache.org/jira/browse/HIVE-25034
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to