[ 
https://issues.apache.org/jira/browse/HIVE-25102?focusedWorklogId=598575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598575
 ]

ASF GitHub Bot logged work on HIVE-25102:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/May/21 13:02
            Start Date: 18/May/21 13:02
    Worklog Time Spent: 10m 
      Work Description: lcspinter commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r634355038



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -284,4 +334,42 @@ private static String getCatalogType(Configuration conf, 
String catalogName) {
       }
     }
   }
+
+  public static class TableCache {
+    private static final Cache<String, Table> tableCache = 
Caffeine.newBuilder()
+        .expireAfterAccess(12, TimeUnit.HOURS).build();
+    private static final Logger LOG = 
LoggerFactory.getLogger(TableCache.class);
+
+    public static void removeTables(Configuration conf) {

Review comment:
       Yes, it makes sense. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 598575)
    Time Spent: 3h 40m  (was: 3.5h)

> Cache Iceberg table objects within same query
> ---------------------------------------------
>
>                 Key: HIVE-25102
>                 URL: https://issues.apache.org/jira/browse/HIVE-25102
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> We run Catalogs.loadTable(configuration, props) plenty of times which is 
> costly.
> We should:
>  - Cache it maybe even globally based on the queryId
>  - Make sure that the query uses one snapshot during the whole execution of a 
> single query



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to