[ 
https://issues.apache.org/jira/browse/HIVE-25085?focusedWorklogId=598750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598750
 ]

ASF GitHub Bot logged work on HIVE-25085:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/May/21 18:22
            Start Date: 18/May/21 18:22
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera commented on pull request #2238:
URL: https://github.com/apache/hive/pull/2238#issuecomment-843421092


   I tried to reproduce this here, but I could not.
   
   Interestingly, not only could I not reproduce this, but I also put in some 
debugging statements and the thrift threads seem to be tied to the thrift 
client. Not sure why this doesn't happen in my environment. 
   
   I still think it's worth pushing this fix though since there's really no 
reason a thrift thread needs to be attached to the client. 
   
   I'm wondering if this is related to HIVE-23925, but I tried running this 20x 
in my environment without my fix and it passed each time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 598750)
    Time Spent: 1h 40m  (was: 1.5h)

> MetaStore Clients are being shared across different sessions
> ------------------------------------------------------------
>
>                 Key: HIVE-25085
>                 URL: https://issues.apache.org/jira/browse/HIVE-25085
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>            Reporter: Steve Carlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The Hive object (and the underlying MetaStoreClient object) seems to be 
> getting shared across different sessions.  While most operations work, there 
> can be occasional glitches.  
> One such noted glitch is that when session 1 ends, it closes the connection.  
> If session 2 then tries an operation, the first try will fail.  Normally this 
> can proceed because the RetryingMetaStoreClient will re-establish a new 
> connection, but in some operations, the retrying logic will not kick in (by 
> design).
> It seems there was an attempt to fix this issue in HIVE-20682.  However, this 
> implementation seems to be flawed.  The HiveSessionImpl object creates a Hive 
> object and makes sure all thread queries belonging to the same session will 
> run with the same Hive object.  The flaw is that the initial Hive Object 
> within HiveSessionImpl is created in thread local storage.  The thread being 
> run at that moment is not session specific.  It belongs to a thread pool that 
> happens to be handling this specific session.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to