[
https://issues.apache.org/jira/browse/HIVE-25091?focusedWorklogId=600170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600170
]
ASF GitHub Bot logged work on HIVE-25091:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/21 04:22
Start Date: 21/May/21 04:22
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r636624386
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -172,10 +172,12 @@ protected Connection getConnection() {
ResultSet rs = null;
Table table = null;
try {
- // rs = fetchTableMetadata(tableName);
- rs = fetchTableViaDBMetaData(tableName);
+ rs = fetchTableMetadata(tableName);
Review comment:
I am not sure I understand this change. Dont we want to use
fetchTableViaDBmetadata? we comment out the implementation in the abstract
class and moved it into subclasses. can you please expand on your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 600170)
Time Spent: 20m (was: 10m)
> Implement connector provider for MSSQL and Oracle
> -------------------------------------------------
>
> Key: HIVE-25091
> URL: https://issues.apache.org/jira/browse/HIVE-25091
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Provide an implementation of Connector provider for MSSQL and Oracle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
