[jira] [Work logged] (HIVE-25179) Support all partition transforms for Iceberg in create table

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-25179?focusedWorklogId=605023&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-605023
 ]

ASF GitHub Bot logged work on HIVE-25179:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/21 08:18
            Start Date: 02/Jun/21 08:18
    Worklog Time Spent: 10m 
      Work Description: lcspinter commented on a change in pull request #2333:
URL: https://github.com/apache/hive/pull/2333#discussion_r643758291



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13455,6 +13469,18 @@ ASTNode analyzeCreateTable(
       }
     }
 
+    if (partitionTransformSpecExists) {
+      try {
+        HiveStorageHandler storageHandler = HiveUtils.getStorageHandler(conf, 
storageFormat.getStorageHandler());

Review comment:
       We need to parse all the tokens in the AST Tree before we can make any 
validation.
   If we have a query like this 
   `CREATE EXTERNAL TABLE ... PARTITIONED BY SPEC (....) STORED BY ICEBERG`, 
the tokens are processed in order.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 605023)
    Time Spent: 4h  (was: 3h 50m)

> Support all partition transforms for Iceberg in create table
> ------------------------------------------------------------
>
>                 Key: HIVE-25179
>                 URL: https://issues.apache.org/jira/browse/HIVE-25179
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Enhance table create syntax with support to partition transforms:
> {code:sql}
> CREATE TABLE ... PARTITIONED BY SPEC(
> year_field year,
> month_field month,
> day_field day,
> hour_field hour,
> truncate_field truncate[3],
> bucket_field bucket[5],
> identity_field identity
> ) STORED BY ICEBERG;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)