[
https://issues.apache.org/jira/browse/HIVE-25128?focusedWorklogId=607873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607873
]
ASF GitHub Bot logged work on HIVE-25128:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 13:46
Start Date: 07/Jun/21 13:46
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #2291:
URL: https://github.com/apache/hive/pull/2291#discussion_r646602792
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -656,10 +656,9 @@ public void createCatalog(Catalog cat) throws
MetaException {
}
@Override
- public void alterCatalog(String catName, Catalog cat)
- throws MetaException, InvalidOperationException {
+ public void alterCatalog(String catName, Catalog cat) {
if (!cat.getName().equals(catName)) {
- throw new InvalidOperationException("You cannot change a catalog's
name");
+ throw new HiveMetaRuntimeException("You cannot change a catalog's name:
" + cat.getName() + " -> " + catName);
Review comment:
Thanks for the input on the error text. I've altered it a bit to make it
more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607873)
Time Spent: 2h 20m (was: 2h 10m)
> Remove Thrift Exceptions From RawStore alterCatalog
> ---------------------------------------------------
>
> Key: HIVE-25128
> URL: https://issues.apache.org/jira/browse/HIVE-25128
> Project: Hive
> Issue Type: Sub-task
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> {code:java|title=RawStore.java}
> /**
> * Alter an existing catalog. Only description and location can be
> changed, and the change of
> * location is for internal use only.
> * @param catName name of the catalog to alter.
> * @param cat new version of the catalog.
> * @throws MetaException something went wrong, usually in the database.
> * @throws InvalidOperationException attempt to change something about the
> catalog that is not
> * changeable, like the name.
> */
> void alterCatalog(String catName, Catalog cat) throws MetaException,
> InvalidOperationException;
> {code}
> Please check out parent task [HIVE-25126] for the motivation here, but I
> would like to remove all Thrift-based Exceptions from the {{RawStore}}
> interface to include MetaException and InvalidOperationException. These
> should be replaced with something that is specific to Hive and not tied to
> the RPC layer.
> I propose instead introducing RuntimeExceptions called
> HiveMetaRuntimeException and sub-class HiveMetaDataAccessException to replace
> these.
> HiveMetaDataAccessException = Unable to load data from underlying data store
> HiveMetaRuntimeException = Generic exception for something that was thrown by
> the RawStore but not specifically handled
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
