[ 
https://issues.apache.org/jira/browse/HIVE-25185?focusedWorklogId=608494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608494
 ]

ASF GitHub Bot logged work on HIVE-25185:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jun/21 14:35
            Start Date: 08/Jun/21 14:35
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647504478



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
       poolLock.lock();
       try {
         while ((result = pool.poll()) == null) {
-          notEmpty.await(100, TimeUnit.MILLISECONDS);
+          LOG.info("Awaiting Tez session to become available in session pool");
+          notEmpty.await(10, TimeUnit.SECONDS);

Review comment:
       Any chance this change can increase the time we actually wait to get a 
session from the pool assuming there is none currently available?
   It looks to me that if the next session becomes available in the next 10ms 
with the new change we might wait 10s instead -- am I missing something ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 608494)
    Time Spent: 1h  (was: 50m)

> Improve Logging On Polling Tez Session from Pool
> ------------------------------------------------
>
>                 Key: HIVE-25185
>                 URL: https://issues.apache.org/jira/browse/HIVE-25185
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to