[
https://issues.apache.org/jira/browse/HIVE-24991?focusedWorklogId=608522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608522
]
ASF GitHub Bot logged work on HIVE-24991:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/21 15:31
Start Date: 08/Jun/21 15:31
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #2264:
URL: https://github.com/apache/hive/pull/2264#discussion_r647558152
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -892,13 +913,20 @@ public boolean next(NullWritable key, VectorizedRowBatch
value) throws IOExcepti
} catch (Exception e) {
throw new IOException("error iterating", e);
}
- if(!includeAcidColumns) {
+ if (!includeAcidColumns) {
//if here, we don't need to filter anything wrt acid metadata columns
//in fact, they are not even read from file/llap
value.size = vectorizedRowBatchBase.size;
value.selected = vectorizedRowBatchBase.selected;
value.selectedInUse = vectorizedRowBatchBase.selectedInUse;
copyFromBase(value);
+
+ if (rowIsDeletedProjected) {
+ rowIsDeletedVector.clear();
+ int ix = rbCtx.findVirtualColumnNum(VirtualColumn.ROWISDELETED);
Review comment:
I started to work on a solution to manage Virtual Column related
information but it lead to a much bigger change.
`VectorizedOrcAcidRowBatchReader` can behave several ways and each of those
behavior worth a separate class after extracting common parts.
So I decided to followed existing logic implemented for RowId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 608522)
Time Spent: 3h (was: 2h 50m)
> Enable fetching deleted rows in vectorized mode
> -----------------------------------------------
>
> Key: HIVE-24991
> URL: https://issues.apache.org/jira/browse/HIVE-24991
> Project: Hive
> Issue Type: Improvement
> Components: Vectorization
> Reporter: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> HIVE-24855 enables loading deleted rows from ORC tables when table property
> *acid.fetch.deleted.rows* is true.
> The goal of this jira is to enable this feature in vectorized orc batch
> reader.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
