[
https://issues.apache.org/jira/browse/HIVE-25081?focusedWorklogId=609526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609526
]
ASF GitHub Bot logged work on HIVE-25081:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 07:45
Start Date: 10/Jun/21 07:45
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2332:
URL: https://github.com/apache/hive/pull/2332#discussion_r648933458
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/metrics/DeltaFilesMetricReporter.java
##########
@@ -206,7 +216,7 @@ public static void backPropagateAcidMetrics(JobConf
jobConf, Configuration conf)
}
public static void close() {
- if (getInstance() != null) {
+ if (getInstance() != null && getInstance().acidMetricsExtEnabled) {
Review comment:
Oh, then probably null checking the executorService would be best here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609526)
Time Spent: 50m (was: 40m)
> Put metrics collection behind a feature flag
> --------------------------------------------
>
> Key: HIVE-25081
> URL: https://issues.apache.org/jira/browse/HIVE-25081
> Project: Hive
> Issue Type: Sub-task
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Most metrics we're creating are collected in AcidMetricsService, which is
> behind a feature flag. However there are some metrics that are collected
> outside of the service. These should be behind a feature flag in addition to
> hive.metastore.metrics.enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
