[ 
https://issues.apache.org/jira/browse/HIVE-25246?focusedWorklogId=612934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612934
 ]

ASF GitHub Bot logged work on HIVE-25246:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jun/21 02:56
            Start Date: 22/Jun/21 02:56
    Worklog Time Spent: 10m 
      Work Description: hmangla98 commented on a change in pull request #2396:
URL: https://github.com/apache/hive/pull/2396#discussion_r655839436



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1339,7 +1340,8 @@ public void commitTxn(CommitTxnRequest rqst)
             // corresponding open txn event.
             LOG.info("Target txn id is missing for source txn id : " + 
sourceTxnId +
                     " and repl policy " + rqst.getReplPolicy());
-            return;
+            throw new NoSuchTxnException("Source transaction: " + 
JavaUtils.txnIdToString(sourceTxnId)

Review comment:
       no, we have only source txn id and the replPolicy. Using this info, we 
query the REPL_TXN_MAP table and get corresponding target txn id and then 
commit this txn.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 612934)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix the clean up of open repl created transactions
> --------------------------------------------------
>
>                 Key: HIVE-25246
>                 URL: https://issues.apache.org/jira/browse/HIVE-25246
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Haymant Mangla
>            Assignee: Haymant Mangla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to