[ 
https://issues.apache.org/jira/browse/HIVE-25234?focusedWorklogId=613453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613453
 ]

ASF GitHub Bot logged work on HIVE-25234:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jun/21 12:26
            Start Date: 22/Jun/21 12:26
    Worklog Time Spent: 10m 
      Work Description: lcspinter commented on a change in pull request #2382:
URL: https://github.com/apache/hive/pull/2382#discussion_r656168619



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -214,7 +219,7 @@ public void 
commitDropTable(org.apache.hadoop.hive.metastore.api.Table hmsTable,
   @Override
   public void preAlterTable(org.apache.hadoop.hive.metastore.api.Table 
hmsTable, EnvironmentContext context)
       throws MetaException {
-    super.preAlterTable(hmsTable, context);
+    setupAlterOperationType(hmsTable, context);

Review comment:
       Yes, this was intentional. The validation of supported alter operation 
types was moved from the superclass to the IcebergMetaHook 
(`setupAlterOperationType`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 613453)
    Time Spent: 2h  (was: 1h 50m)

> Implement ALTER TABLE ... SET PARTITION SPEC to change partitioning on 
> Iceberg tables
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-25234
>                 URL: https://issues.apache.org/jira/browse/HIVE-25234
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Provide a way to change the schema and the Iceberg partitioning specification 
> using Hive syntax.
> {code:sql}
> ALTER TABLE tbl SET PARTITION SPEC(...)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to