[
https://issues.apache.org/jira/browse/HIVE-25268?focusedWorklogId=614984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614984
]
ASF GitHub Bot logged work on HIVE-25268:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/21 13:17
Start Date: 25/Jun/21 13:17
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #2409:
URL: https://github.com/apache/hive/pull/2409#discussion_r658755973
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
##########
@@ -51,18 +50,17 @@
*/
@Description(name = "date_format", value = "_FUNC_(date/timestamp/string, fmt)
- converts a date/timestamp/string "
+ "to a value of string in the format specified by the date format fmt.",
- extended = "Supported formats are SimpleDateFormat formats - "
- +
"https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html. "
+ extended = "Supported formats are DateTimeFormatter formats - "
+ +
"https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html.
"
Review comment:
Personally, I am in favor of using the new API. However, I am sure that
a user/client will discover that they get different results and may come back
to us complaining about it. Still I think it is a good idea to use the new
`DateTimeFormatter` so I would suggest to clearly indicate this small change of
behavior in the JIRA and move forward.
Other than that since we are enhancing the API of `date_format` we should
probably consider adding a few more tests in `TestGenericUDFDateFormat` with
the supported patterns (could be done in a follow up I guess).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 614984)
Time Spent: 9h 10m (was: 9h)
> date_format udf doesn't work for dates prior to 1900 if the timezone is
> different from UTC
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-25268
> URL: https://issues.apache.org/jira/browse/HIVE-25268
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 3.1.0, 3.1.1, 3.1.2, 4.0.0
> Reporter: Nikhil Gupta
> Assignee: Nikhil Gupta
> Priority: Major
> Labels: pull-request-available, timestamp
> Fix For: 4.0.0
>
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> *Hive 1.2.1*:
> {code:java}
> select date_format('1400-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+--+
> | _c0 |
> +--------------------------+--+
> | 1400-01-14 01:00:00 ICT |
> +--------------------------+--+
> select date_format('1800-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+--+
> | _c0 |
> +--------------------------+--+
> | 1800-01-14 01:00:00 ICT |
> +--------------------------+--+
> {code}
> *Hive 3.1, Hive 4.0:*
> {code:java}
> select date_format('1400-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+
> | _c0 |
> +--------------------------+
> | 1400-01-06 01:17:56 ICT |
> +--------------------------+
> select date_format('1800-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+
> | _c0 |
> +--------------------------+
> | 1800-01-14 01:17:56 ICT |
> +--------------------------+
> {code}
> VM timezone is set to 'Asia/Bangkok'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
