[
https://issues.apache.org/jira/browse/HIVE-25360?focusedWorklogId=626105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626105
]
ASF GitHub Bot logged work on HIVE-25360:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/21 12:31
Start Date: 21/Jul/21 12:31
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2508:
URL: https://github.com/apache/hive/pull/2508#discussion_r673929062
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -609,6 +606,121 @@ public void testAlterChangeColumn() throws IOException {
Assert.assertArrayEquals(new Object[]{0L, "Brown"}, result.get(0));
Assert.assertArrayEquals(new Object[]{1L, "Green"}, result.get(1));
Assert.assertArrayEquals(new Object[]{2L, "Pink"}, result.get(2));
+
+ }
+
+ // Tests CHANGE COLUMN feature similarly like above, but with a more complex
schema, aimed to verify vectorized
+ // reads support the feature properly, also combining with other schema
changes e.g. ADD COLUMN
+ @Test
+ public void testSchemaEvolutionOnVectorizedReads() throws Exception {
+ // Currently only ORC, but in the future this should run against each
fileformat with vectorized read support.
+ Assume.assumeTrue("Vectorized reads only.", isVectorized);
+
+ Schema orderSchema = new Schema(
+ optional(1, "order_id", Types.IntegerType.get()),
Review comment:
Do we handle complex types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626105)
Time Spent: 0.5h (was: 20m)
> Iceberg vectorized ORC reads don't support column reordering
> ------------------------------------------------------------
>
> Key: HIVE-25360
> URL: https://issues.apache.org/jira/browse/HIVE-25360
> Project: Hive
> Issue Type: Bug
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-25256 added support for Iceberg backed tables to support CHANGE COLUMN
> statement. These include type, name and order changes to the schema. Native
> ORC tables only support renames, but with the help of Iceberg as an
> intermediary table format layer, this can be achieved, and works well for
> non-vectorized reads already.
> We should adjust the vectorized read path to support the same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
