[ 
https://issues.apache.org/jira/browse/HIVE-24316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403937#comment-17403937
 ] 

Panagiotis Garefalakis commented on HIVE-24316:
-----------------------------------------------

Hey [~glapark] thanks for bringing this up -- taking a look at 
MemoryManagerImpl looks like checkMemory() is the new method that determines if 
the scale has changed and since ORC-361 removed getTotalMemoryPool() calls from 
multiple places we are loosing the effect of controlling the memory pool.

The intention behind  LlapAwareMemoryManager  was to have memory per executor 
instead of the entire heap since multiple writers are involved. An idea could 
be to restore getTotalMemoryPool calls where needed .

> Upgrade ORC from 1.5.6 to 1.5.8 in branch-3.1
> ---------------------------------------------
>
>                 Key: HIVE-24316
>                 URL: https://issues.apache.org/jira/browse/HIVE-24316
>             Project: Hive
>          Issue Type: Bug
>          Components: ORC
>    Affects Versions: 3.1.3
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.1.3
>
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> This will bring eleven bug fixes.
>  * ORC 1.5.7: [https://issues.apache.org/jira/projects/ORC/versions/12345702]
>  * ORC 1.5.8: [https://issues.apache.org/jira/projects/ORC/versions/12346462]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to