[ https://issues.apache.org/jira/browse/HIVE-25479?focusedWorklogId=641335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641335 ]
ASF GitHub Bot logged work on HIVE-25479: ----------------------------------------- Author: ASF GitHub Bot Created on: 24/Aug/21 21:07 Start Date: 24/Aug/21 21:07 Worklog Time Spent: 10m Work Description: vihangk1 opened a new pull request #2601: URL: https://github.com/apache/hive/pull/2601 ### What changes were proposed in this pull request? This patch fixes a race condition on the JDBC driver side when it brings up a browser to do a SAML based SSO authentication. The race condition occurs sometimes in virtual environment and has to do with the port state when the browser sends a POST request to the driver. More details are available in JIRA. ### Why are the changes needed? To fix the bug. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The issue is not reproducible on my dev machine. However, I added some new tests to cover the new changes and additionally the patch was manually verified on Windows 10 VMs where the issue was reproducible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 641335) Remaining Estimate: 0h Time Spent: 10m > Browser SSO auth may fail intermittently on chrome browser in virtual > environments > ---------------------------------------------------------------------------------- > > Key: HIVE-25479 > URL: https://issues.apache.org/jira/browse/HIVE-25479 > Project: Hive > Issue Type: Bug > Components: JDBC > Reporter: Vihang Karajgaonkar > Assignee: Vihang Karajgaonkar > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When browser based SSO is enabled the Hive JDBC driver might miss the POST > requests coming from the browser which provide the one-time token issued by > HS2s after the SAML flow completes. The issue was observed mostly in virtual > environments on Windows. > The issue seems to be that when the driver binds to a port even though the > port is in LISTEN state, if the browser issues posts request on the port > before it goes into ACCEPT state the result is non-deterministic. On native > OSes we observed that the connection is buffered and is received by the > driver when it begins accepting the connections. In case of VMs it is > observed that even though the connection is buffered and presented when the > port goes into ACCEPT mode, the payload of the request or the connection > itself is lost. This race condition causes the driver to wait for the browser > until it timesout and the browser keeps waiting for a response from the > driver. -- This message was sent by Atlassian Jira (v8.3.4#803005)