[ 
https://issues.apache.org/jira/browse/HIVE-25527?focusedWorklogId=651519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-651519
 ]

ASF GitHub Bot logged work on HIVE-25527:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Sep/21 08:03
            Start Date: 16/Sep/21 08:03
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #2645:
URL: https://github.com/apache/hive/pull/2645#discussion_r709881332



##########
File path: 
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1820,6 +1830,8 @@ private static boolean 
removeFromRunningTaskMap(TreeMap<Integer, TreeSet<TaskInf
               hostList.add(nodeInfo);
             }
           }
+        } else {
+          LOG.warn("Null NodeInfo when attempting to get available resources");

Review comment:
       Maybe also add workerIdentity in the warn message? 

##########
File path: 
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1820,6 +1830,8 @@ private static boolean 
removeFromRunningTaskMap(TreeMap<Integer, TreeSet<TaskInf
               hostList.add(nodeInfo);
             }
           }
+        } else {
+          LOG.warn("Null NodeInfo when attempting to get available resources");

Review comment:
       Maybe also add workerIdentity to the WARN message? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 651519)
    Time Spent: 50m  (was: 40m)

> LLAP Scheduler task exits with fatal error if the executor node is down.
> ------------------------------------------------------------------------
>
>                 Key: HIVE-25527
>                 URL: https://issues.apache.org/jira/browse/HIVE-25527
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> In case the executor host has gone down, activeInstances will be updated with 
> null. So we need to check for empty/null values before accessing it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to