[ https://issues.apache.org/jira/browse/HIVE-25572?focusedWorklogId=658034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658034 ]
ASF GitHub Bot logged work on HIVE-25572: ----------------------------------------- Author: ASF GitHub Bot Created on: 30/Sep/21 00:47 Start Date: 30/Sep/21 00:47 Worklog Time Spent: 10m Work Description: kasakrisz opened a new pull request #2682: URL: https://github.com/apache/hive/pull/2682 ### What changes were proposed in this pull request? Add missing bracket when assembling direct sql query to get materialization invalidation info. ### Why are the changes needed? The query was syntactically incorrect and blocked incremental materialized view rebuild when one or more MV source table had uncommitted transaction when the MV was last rebuilt and the snapshot was taken however they might be committed later and has an affect on the next MV rebuild. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` mvn test -Dtest=TestTxnHandler -pl ql ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 658034) Time Spent: 1.5h (was: 1h 20m) > Exception while querying materialized view invalidation info > ------------------------------------------------------------ > > Key: HIVE-25572 > URL: https://issues.apache.org/jira/browse/HIVE-25572 > Project: Hive > Issue Type: Bug > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > {code:java} > 2021-09-29T00:33:02,971 WARN [main] txn.TxnHandler: Unable to retrieve > materialization invalidation information: completed transaction components. > java.sql.SQLSyntaxErrorException: Syntax error: Encountered "<EOF>" at line > 1, column 234. > at > org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at > org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at > org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.EmbedPreparedStatement42.<init>(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.jdbc.Driver42.newEmbedPreparedStatement(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at > com.zaxxer.hikari.pool.ProxyConnection.prepareStatement(ProxyConnection.java:311) > ~[HikariCP-2.6.1.jar:?] > at > com.zaxxer.hikari.pool.HikariProxyConnection.prepareStatement(HikariProxyConnection.java) > ~[HikariCP-2.6.1.jar:?] > at > org.apache.hadoop.hive.metastore.tools.SQLGenerator.prepareStmtWithParameters(SQLGenerator.java:169) > ~[classes/:?] > at > org.apache.hadoop.hive.metastore.txn.TxnHandler.executeBoolean(TxnHandler.java:2598) > [classes/:?] > at > org.apache.hadoop.hive.metastore.txn.TxnHandler.getMaterializationInvalidationInfo(TxnHandler.java:2575) > [classes/:?] > at > org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testGetMaterializationInvalidationInfo(TestTxnHandler.java:1910) > [test-classes/:?] > at > org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testGetMaterializationInvalidationInfo(TestTxnHandler.java:1875) > [test-classes/:?] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[?:1.8.0_112] > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > ~[?:1.8.0_112] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_112] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112] > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > [junit-4.13.jar:4.13] > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > [junit-4.13.jar:4.13] > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > [junit-4.13.jar:4.13] > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > [junit-4.13.jar:4.13] > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > [junit-4.13.jar:4.13] > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > [junit-4.13.jar:4.13] > at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > [junit-4.13.jar:4.13] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > [junit-4.13.jar:4.13] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > [junit-4.13.jar:4.13] > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > [junit-4.13.jar:4.13] > at org.junit.runner.JUnitCore.run(JUnitCore.java:137) > [junit-4.13.jar:4.13] > at > com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) > [junit-rt.jar:?] > at > com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) > [junit-rt.jar:?] > at > com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235) > [junit-rt.jar:?] > at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) > [junit-rt.jar:?] > Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: > Encountered "<EOF>" at line 1, column 234. > at org.apache.derby.iapi.error.StandardException.newException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.iapi.error.StandardException.newException(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at > org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown > Source) ~[derby-10.14.1.0.jar:?] > at org.apache.derby.impl.sql.GenericStatement.prepare(Unknown Source) > ~[derby-10.14.1.0.jar:?] > at > org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(Unknown > Source) ~[derby-10.14.1.0.jar:?] > ... 39 more > {code} > Problematic query > {code:java} > SELECT "CTC_UPDATE_DELETE" > FROM "COMPLETED_TXN_COMPONENTS" > WHERE "CTC_UPDATE_DELETE" ='Y' > AND ( > ( > "CTC_DATABASE"=? AND "CTC_TABLE"=? AND > ( > "CTC_WRITEID" > 1 OR "CTC_WRITEID" IN(2) > ) > ) > -- Missing ) > AND "CTC_TXNID" <= 10 AND "CTC_TXNID" NOT IN(6,11) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)